Skip to content

[5667][19.0][MIG] portal_project_task_hide_timesheet: Migration to 19.0#49

Open
AungKoKoLin1997 wants to merge 7 commits into
19.0from
19.0-mig-portal_project_task_hide_timesheet
Open

[5667][19.0][MIG] portal_project_task_hide_timesheet: Migration to 19.0#49
AungKoKoLin1997 wants to merge 7 commits into
19.0from
19.0-mig-portal_project_task_hide_timesheet

Conversation

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

Hiding timesheets only through the portal template left the timesheet
report reachable: /my/tasks/<id>?report_type=pdf renders all of a task's
timesheets via sudo, regardless of the template variable, so a portal
user could still download them.

Override account.analytic.line._show_portal_timesheets() to return False
(the core hook that drives the template variable, replacing the fragile
xpath that set it) and gate the report controller on the same method, so
both the page and the downloadable report are consistently suppressed.

Also add the manifest summary and maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants